[BACKPORT] type casted $qty to float in \Magento\Catalog\Model\Produc…#18424
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom Oct 23, 2018
Merged
Conversation
okorshenko
suggested changes
Oct 7, 2018
- remove typecasting from the setter
okorshenko
approved these changes
Oct 19, 2018
Contributor
|
Hi @okorshenko, thank you for the review. |
Contributor
|
Hi @lewisvoncken. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t::setQty()
type casted $qty to float in \Magento\Catalog\Model\Product::setQty()
Description
Backport PR #18149
\Magento\Catalog\Model\Product::getQty() should return float/double now, as mentioned in it's Doc-block
Fixed Issues (if relevant)
Manual testing scenarios
checkout_cart_product_add_after\Magento\Catalog\Model\ProductgetQtymethod of the above-mentioned class would return afloat/doubleinstead ofstring, as expectedContribution checklist